Fix password enforcement #8745
Merged
Fix password enforcement #8745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard realization: the passwordEnforced capability member names are misleading. They don't map to permissions, but to the existing roles. That is most obvious with the "read_write" password enforcement, which needs "read" and "create", but doesn't accept "update" and "delete". Not accepting "update" is not reasonable on a "read_write".
kulmann
commented
Mar 29, 2023
| onError(e) | ||
| console.error(e) | ||
| this.showMessage({ | ||
| title: this.$gettext('Failed to create link'), | ||
| status: 'danger' | ||
| }) | ||
| }) | ||
| return |
There was a problem hiding this comment.
prevents a fall through to the success message when the request resulted in an error status code. previously an error would cause both the error and the success message. 
kulmann
commented
Mar 29, 2023
| }) | ||
| return |
There was a problem hiding this comment.
prevents a fall through to the success message when the request resulted in an error status code. previously an error would cause both the error and the success message.
kulmann
commented
Mar 29, 2023
|
|
||
| /** | ||
| * `passwordEnforced` members are oddly designed. they look like they map to permissions, | ||
| * but in reality they map to role names. hence the comparison with specific link roles. |
There was a problem hiding this comment.
wanted to add that I feel betrayed by the capability. It looks so promising regarding permissions... but it's a big nope in reality.
kulmann
requested review from
JammingBen and
dschmidt
and removed request for
JammingBen
|
SonarCloud Quality Gate failed. |
dschmidt
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix some quirks of the public link password enforcement.
Types of changes
Checklist: