Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterItem filter: Add label and make label and placeholder customizable #8711

Merged
merged 11 commits into from
Mar 28, 2023
Merged

FilterItem filter: Add label and make label and placeholder customizable #8711

merged 11 commits into from
Mar 28, 2023

Conversation

hurradieweltgehtunter
Copy link
Contributor

@hurradieweltgehtunter hurradieweltgehtunter commented Mar 27, 2023 •
edited
Loading

Description

Make the placeholder on text input field for the ItemFilter component editable via prop

Related Issue

Motivation and Context

Adds possibility to customized the filter input

Screenshots (if appropriate):

before

grafik

after

with custom placeholder and label

grafik

default
grafik

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

@hurradieweltgehtunter hurradieweltgehtunter added the Status:Needs-Review Needs review from a maintainer label Mar 27, 2023
@hurradieweltgehtunter hurradieweltgehtunter self-assigned this Mar 27, 2023
@hurradieweltgehtunter hurradieweltgehtunter changed the title make FilterItem placeholder customizable FilterItem: Add label and make label and placeholder customizable Mar 27, 2023
@hurradieweltgehtunter hurradieweltgehtunter changed the title FilterItem: Add label and make label and placeholder customizable FilterItem filter: Add label and make label and placeholder customizable Mar 27, 2023
@hurradieweltgehtunter
Copy link
Contributor Author

How do you normally handle code coverage fails?
In this example a computed property (getLabel) is not covered by test but the input field itself, which includes the computed property, is tested.
Should I add a specific computed property test? Would be a duplicate IMO 🤷

JammingBen
JammingBen suggested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you normally handle code coverage fails?

SonarCloud can be quite buggy when determining the coverage on new code. You tested the 2 new properties perfectly fine.

JammingBen
JammingBen suggested changes Mar 28, 2023
View reviewed changes
JammingBen
JammingBen approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Another linter-run is required though.

@hurradieweltgehtunter
Copy link
Contributor Author

Nice 👍 Another linter-run is required though.

you were too fast :D

done

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

37.5% 37.5% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit d010cf7 into master Mar 28, 2023
@hurradieweltgehtunter
Copy link
Contributor Author

hurradieweltgehtunter commented Mar 28, 2023 •
edited
Loading

hu, SonarCloud bug? buggy code is not mine 🤷 Ignore?

@delete-merged-branch delete-merged-branch bot deleted the filterchip-placeholder-editable branch March 28, 2023 10:59
@JammingBen
Copy link
Contributor

hu, SonarCloud bug? buggy code is not mine 🤷 Ignore?

Ignore, yes 😄 SonarCloud often analyses not only your changes, but the whole file.

@hurradieweltgehtunter hurradieweltgehtunter mentioned this pull request Mar 29, 2023
Merged
5 tasks
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@hurradieweltgehtunter hurradieweltgehtunter

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customize input fields on FilterItem
2 participants
@hurradieweltgehtunter @JammingBen