Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] fix: appProviders capability check #8705

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[full-ci] fix: appProviders capability check #8705

merged 1 commit into from
Mar 24, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Mar 24, 2023

Description

App provider capabilities check was broken (introduced in file action composable refactoring).

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested review from dschmidt and JammingBen March 24, 2023 11:34
@kulmann kulmann self-assigned this Mar 24, 2023
@kulmann kulmann force-pushed the fix-open-in-external-app branch from f97c8a3 to 2f91009 Compare March 24, 2023 11:45
@kulmann kulmann force-pushed the fix-open-in-external-app branch from 2f91009 to ae6b443 Compare March 24, 2023 11:52
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/34165/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34165/tracing/admin-deletes-group-admin-2023-3-24-12-08-03.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34165/tracing/quick-link-alice-2023-3-24-12-11-47.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34165/tracing/quick-link-anonymous-2023-3-24-12-11-54.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34165/tracing/user-login-can-be-managed-in-the-admin-settings-admin-2023-3-24-12-09-37.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34165/tracing/user-login-can-be-managed-in-the-admin-settings-admin-2023-3-24-12-09-42.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34165/tracing/user-login-can-be-managed-in-the-admin-settings-alice-2023-3-24-12-09-41.zip

@kulmann kulmann merged commit 318fd46 into master Mar 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-open-in-external-app branch March 24, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open in app stopped working
3 participants
@kulmann @ownclouders @dschmidt