Add space sorting options: size and mdate
#8675
Conversation
JammingBen
force-pushed
the
add-space-sorting-options
branch
2 times, most recently
from
167738d to
41dd3a8
Compare
| @@ -51,13 +51,15 @@ | |||
| v-oc-tooltip="showSpaceMemberLabel" | |||
| :aria-label="showSpaceMemberLabel" | |||
| appearance="raw" | |||
| @click="openSidebarSharePanel(resource)" | |||
| @click="openSidebarSharePanel(resource as SpaceResource)" | |||
There was a problem hiding this comment.
Would be nice to figure out how to type slots :-D
There was a problem hiding this comment.
Apparently you can type the context variables directly, see 299192a. I would like to use SpaceActionOptions here, but the import gets removed by the linter... :(
Edit: nvm, I un-did that commit because that's not what we want.
There was a problem hiding this comment.
Turns out IntelliJ is smart enough to deduce the type from the slot declaration, vue-tsc apparently isn't... anyhow this is the correct fix, as resource-tiles component just deals with resources and that's why we need to downcast here.
Would be great if Vue had support for generic components 👀
There was a problem hiding this comment.
haha +1 for generic components 😅
JammingBen
force-pushed
the
add-space-sorting-options
branch
from
299192a to
13f232c
Compare
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/34010/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34010/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-3-22-02-48-35.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34010/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-3-22-02-49-03.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34010/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2023-3-22-02-49-09.zip |
| @@ -2,6 +2,7 @@ import { ref, Ref, computed, unref, isRef } from 'vue' | |||
| import { MaybeRef, ReadOnlyRef } from 'web-pkg/src/utils' | |||
| import { useRouteName, useRouteQueryPersisted, QueryValue } from 'web-pkg/src/composables' | |||
| import { SortConstants } from './constants' | |||
| import { useRouter } from 'vue-router' | |||
There was a problem hiding this comment.
Are we sure this always works? I had problems with this composable in the past and no time to debug
There was a problem hiding this comment.
Ohh good catch! I also had problems, I'll change that.
There was a problem hiding this comment.
out of curiosity, what kind of problems?
There was a problem hiding this comment.
Not returning our router instance or even: no instance at all.
As I said I haven't debugged it, so I can't tell you what exactly is going on.
| @@ -51,13 +51,15 @@ | |||
| v-oc-tooltip="showSpaceMemberLabel" | |||
| :aria-label="showSpaceMemberLabel" | |||
| appearance="raw" | |||
| @click="openSidebarSharePanel(resource)" | |||
| @click="openSidebarSharePanel(resource as SpaceResource)" | |||
There was a problem hiding this comment.
Turns out IntelliJ is smart enough to deduce the type from the slot declaration, vue-tsc apparently isn't... anyhow this is the correct fix, as resource-tiles component just deals with resources and that's why we need to downcast here.
Would be great if Vue had support for generic components 👀
JammingBen
force-pushed
the
add-space-sorting-options
branch
from
13f232c to
461e2de
Compare
|
SonarCloud Quality Gate failed. |
Related Issue
sortByandsortDirboth change #8409Screenshots (if appropriate):
Types of changes