Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't run into early return in password enforcement check #8623

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix: don't run into early return in password enforcement check #8623

merged 1 commit into from
Mar 15, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Mar 15, 2023

Description

The isPasswordEnforcedFor check in public link creation / editing was basically ignoring the permission bits of the selected role and always did an early return on the first password enforcement capability that was true. Fixed by not returning early anymore. 😆

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann mentioned this pull request Mar 15, 2023
Closed
@kulmann kulmann requested review from micbar and JammingBen March 15, 2023 21:50
@kulmann kulmann self-assigned this Mar 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

28.6% 28.6% Coverage
0.0% 0.0% Duplication

micbar
micbar approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulmann kulmann merged commit ba644f6 into master Mar 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-password-enforced-check branch March 15, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect public link password enforcement capability
2 participants
@kulmann @micbar