Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quota modal text for users #8603

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Fix quota modal text for users #8603

merged 2 commits into from
Mar 14, 2023

Conversation

JammingBen
Copy link
Contributor

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Mar 13, 2023
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks about strings. Hope those make sense. Otherwise good 👍

Co-authored-by: Benedikt Kulmann <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.2% 62.2% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen requested a review from kulmann March 14, 2023 07:50
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💪

@kulmann kulmann merged commit 2b30b11 into master Mar 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-user-quota-modal-text branch March 14, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin-settings user list: edit quota batch action title is wrong
3 participants