[test-only] E2e. changing user #8602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
41 tasks
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/33582/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33582/tracing/user-should-be-able-to-read-and-dismiss-notifications-alice-2023-3-13-12-50-27.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33582/tracing/user-should-be-able-to-read-and-dismiss-notifications-brian-2023-3-13-12-50-33.zip |
ScharfViktor
force-pushed
the
changeUser
branch
2 times, most recently
from
badb527 to
4d3ec38
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
JammingBen
approved these changes
Mar 14, 2023
Comment on lines
+260
to
+268
| const newUser = this.usersEnvironment.createUser({ | ||
| key: value, | ||
| user: { | ||
| id: value, | ||
| displayName: '', | ||
| password: 'password', | ||
| email: '' | ||
| } | ||
| }) |
There was a problem hiding this comment.
Out of curiosity: why not call this.usersEnvironment.getUser() here instead?
There was a problem hiding this comment.
then we get error user with key anna not found.
https://github.com/owncloud/web/blob/master/tests/e2e/support/environment/userManagement.ts#L8-L9
We need create anna in the store before deleting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created test for editing user