De-duplicate event handling to prevent errors on Draw-io #8576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/33573/55/1 |
|
Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/33573/73/1 |
kulmann
approved these changes
Mar 13, 2023
|
@diocas could you rebase your PR please? Notifications acceptance tests have been removed in |
diocas
force-pushed
the
up_drawio_load_bug
branch
from
4d1e8f8 to
8d84102
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dschmidt
approved these changes
Mar 13, 2023
86 tasks
tbsbdr
added
Platform:oCIS
Platform:Web
Early-Adopter:CERN
and removed
Platform:oCIS
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users navigated out of Draw-io and returned afterwards, old event handlers were kept, which failed trying to look for iframes that no longer existed.
This fix removes the handlers when exiting, preventing these user visible errors.