Fix custom permissions checkbox selection #8567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
commented
Mar 8, 2023
| methods: { | ||
| setChecked: function (value) { | ||
| if (typeof value === 'boolean') { | ||
| this.checked = value |
There was a problem hiding this comment.
As far as I can see, this.checked does not exist, so this code did not make any sense.
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Mar 8, 2023
delete-merged-branch
bot
deleted the
fix-custom-permission-checkbox-select
branch
ownclouders
pushed a commit
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Probably a regression of Vue 3.
Related Issue
Types of changes