Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Change default permissions to capablities #8566

Merged
merged 19 commits into from
Mar 9, 2023
Merged

[full-ci] Change default permissions to capablities #8566

merged 19 commits into from
Mar 9, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Mar 8, 2023 •
edited
Loading

Description

We've added the option to change the default quickactions role via capabilities.
See #8547

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Mar 8, 2023 •
edited
Loading

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/33463/53/1
💥 The oCISBasic tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

ownclouders commented Mar 8, 2023 •
edited
Loading

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/33438/45/1
💥 The oC10XGAPortraitNotifications tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/33432/49/1
💥 The oC10iPhoneNotifications tests pipeline failed. The build has been cancelled.

@lookacat lookacat marked this pull request as ready for review March 8, 2023 10:07
kulmann
kulmann previously requested changes Mar 8, 2023
View reviewed changes
packages/web-app-files/src/helpers/share/link.ts Outdated Show resolved Hide resolved
JammingBen
JammingBen reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add it in CreateQuickLink.vue as well 🙂

@lookacat lookacat changed the title Change default permissions to capablities [full-ci] Change default permissions to capablities Mar 8, 2023
@lookacat lookacat requested review from JammingBen and kulmann March 8, 2023 14:05
@kulmann kulmann dismissed their stale review March 8, 2023 14:51

dismissing my review because I'm OOTO the next two days

@lookacat lookacat requested a review from JammingBen March 9, 2023 10:16
@lookacat lookacat requested a review from JammingBen March 9, 2023 11:40
JammingBen
JammingBen reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only a few small nitpicks left.

Rebasing with current master should remove the failing notification pipelines.

packages/web-app-files/src/helpers/share/link.ts Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Links/CreateQuickLink.vue Outdated Show resolved Hide resolved
@lookacat lookacat force-pushed the 3474-quickactions-configurable-capabilities branch from 0863d20 to 72d87aa Compare March 9, 2023 12:57
@lookacat lookacat requested a review from JammingBen March 9, 2023 13:06
@lookacat lookacat requested a review from JammingBen March 9, 2023 14:20
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

59.0% 59.0% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit 4b8d5a8 into master Mar 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the 3474-quickactions-configurable-capabilities branch March 9, 2023 15:46
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann left review comments

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Make link-quickaction configurable via capabilities
4 participants
@lookacat @ownclouders @kulmann @JammingBen