[full-ci] Add support for a public link permission #8541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/33338/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33338/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-3-6-01-58-11.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33338/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-3-6-01-58-40.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33338/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2023-3-6-01-58-46.zip |
JammingBen
force-pushed
the
public-link-permission
branch
from
e966f63 to
9e5cf26
Compare
|
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/33332/69/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicManagement-shareByPublicLink_feature-L83.png |
JammingBen
changed the title
JammingBen
force-pushed
the
public-link-permission
branch
2 times, most recently
from
2e6c442 to
858e6ef
Compare
JammingBen
force-pushed
the
public-link-permission
branch
from
858e6ef to
1fd71f2
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
reviewed
Mar 6, 2023
| try { | ||
| const { | ||
| data: { permissions } | ||
| } = await httpClient.post('/api/v0/settings/permissions-list', { account_uuid: user.uuid }) | ||
| return permissions || [] | ||
| return permissions || oC10DefaultPermissions |
There was a problem hiding this comment.
Why not keep the fallback to [] if the call succeeds? 🤔
There was a problem hiding this comment.
Because the call actually succeeds with oC10. It just doesn't return permissions the way we want.
kulmann
approved these changes
Mar 6, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the public link permission
PublicLink.Write.all. Users without this permission won't be able to create public links (except for oC10 instances where this permission is being set implicitly).Related Issue
Screenshots (if appropriate):
Types of changes