New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change behaviour of user filters to `OR` #8525

Merged

kulmann merged 2 commits into master from user-filter-or-behaviour

Mar 6, 2023

Contributor

JammingBen commented Mar 2, 2023 •

edited

Loading

Description

Change user filter for groups and roles to have an OR behaviour. So if you select both groups physics-lovers and physics-haters, it will result in users that are in either of those groups. Combining different filters like groups and roles still concatenates via AND.

Related Issue

Fixes [admin-settings] User: Filter by multiple groups, unexpected outcome #8469

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests


          Change behaviour of user filters to 'OR'

16709ae

JammingBen self-assigned this


          Fix unit tests

4a37dab

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

JammingBen marked this pull request as ready for review

March 6, 2023 07:44

JammingBen requested review from lookacat, AlexAndBear and kulmann

March 6, 2023 07:47

kulmann approved these changes

View reviewed changes

Member

kulmann left a comment

Nice 💪

kulmann merged commit f73683c into master

delete-merged-branch bot deleted the user-filter-or-behaviour branch

March 6, 2023 11:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet