Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Refactor notifications and make them work with oCIS #8518

Merged
merged 8 commits into from
Mar 7, 2023
Merged

[full-ci] Refactor notifications and make them work with oCIS #8518

merged 8 commits into from
Mar 7, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Mar 1, 2023 •
edited
Loading

Needs owncloud/ocis#5699.

Currently known issues on the backend side:

  • Timestamps always show the current time
  • share removed notification does not work yet (shows removed from space event instead)
  • space deleted notification does not work yet
  • Capabilities are missing

Related Issue

Screenshots

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

To-Dos:

@JammingBen JammingBen self-assigned this Mar 1, 2023
@owncloud owncloud deleted a comment from update-docs bot Mar 2, 2023
@JammingBen JammingBen changed the title Refactor notifications and make them work with oCIS [full-cui] Refactor notifications and make them work with oCIS Mar 2, 2023
@JammingBen JammingBen changed the title [full-cui] Refactor notifications and make them work with oCIS [full-ci] Refactor notifications and make them work with oCIS Mar 2, 2023
@ownclouders
Copy link
Contributor

ownclouders commented Mar 2, 2023 •
edited
Loading

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/33284/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33284/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-3-3-07-07-42.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33284/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-3-3-07-08-12.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33284/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2023-3-3-07-08-18.zip

@JammingBen JammingBen force-pushed the ocis-notifications branch 4 times, most recently from 0c6b3d5 to 23944f2 Compare March 3, 2023 07:23
JammingBen added a commit that referenced this pull request Mar 3, 2023
@JammingBen
Add changelog item for #8518
aafe737
@JammingBen JammingBen force-pushed the ocis-notifications branch from c13b609 to aafe737 Compare March 3, 2023 12:26
@JammingBen JammingBen mentioned this pull request Mar 3, 2023
Merged
5 tasks
JammingBen
JammingBen commented Mar 3, 2023
View reviewed changes
packages/web-runtime/src/components/Topbar/Notifications.vue
Comment on lines +166 to +168
const setAdditionalData = () => {
loading.value = true
for (const notification of unref(notifications)) {
notification.computedMessage = getMessage(notification)
notification.computedLink = getLink(notification)
}
loading.value = false
}
Copy link
Contributor Author

@JammingBen JammingBen Mar 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to separate the additional data from the fetchNotificationsTask and only load it when the notifications drop menu is open. The reason behind this is because I don't know how expensive it will get with a bunch of notifications. Web polls notifications actively every 30 seconds, there is no need to load additional data every time.

I don't see any disadvantages with that approach, but I also don't now if it's necessary. Feedback welcome!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea indeed 👍 let's do it like that.

JammingBen added a commit that referenced this pull request Mar 3, 2023
@JammingBen
Add changelog item for #8518
002479e
@JammingBen JammingBen force-pushed the ocis-notifications branch from aafe737 to 002479e Compare March 3, 2023 14:10
@JammingBen JammingBen force-pushed the ocis-notifications branch from 002479e to 22d3dfb Compare March 6, 2023 07:38
@JammingBen
Copy link
Contributor Author

JammingBen commented Mar 6, 2023 •
edited
Loading

Status: currently waiting for the backend to finish the rest of the implementation.

Edit: Ready now! Needs owncloud/ocis#5699 though.

@JammingBen JammingBen marked this pull request as ready for review March 6, 2023 12:42
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

81.0% 81.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit e579257 into master Mar 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the ocis-notifications branch March 7, 2023 21:24
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@lookacat lookacat Awaiting requested review from lookacat

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Mark all Notifications as read [Web] Render basic set of notification items
3 participants
@JammingBen @ownclouders @kulmann