Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile resize follow up #8483

Merged
merged 8 commits into from
Feb 22, 2023
Merged

Tile resize follow up #8483

merged 8 commits into from
Feb 22, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Feb 21, 2023 •
edited
Loading

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Feb 21, 2023
@update-docs
Copy link

update-docs bot commented Feb 21, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen force-pushed the tile-resize-follow-up branch from dd3ada5 to e2bc1b8 Compare February 21, 2023 10:27
@JammingBen JammingBen force-pushed the tile-resize-follow-up branch from f2b30c0 to bac147f Compare February 21, 2023 13:40
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review February 22, 2023 09:04
lookacat
lookacat approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things but not a dealbreaker LGTM 👍🏼

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

91.2% 91.2% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 611c61d into master Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the tile-resize-follow-up branch February 22, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tiles view] Resize tiles
2 participants
@JammingBen @lookacat