Change/streamline editor autosave #8457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
force-pushed
the
change/streamline-editor-autosave
branch
from
2be585d to
376570a
Compare
kulmann
requested changes
Feb 16, 2023
| @@ -37,6 +37,10 @@ const state = { | |||
| options: { | |||
| contextHelpers: true, | |||
| defaultExtension: 'files', | |||
| editor: { | |||
| autosaveEnabled: false, | |||
| autosaveInterval: 120000 | |||
There was a problem hiding this comment.
Like I said earlier in a zoom call, I'm not a fan of configuring this in ms. I know that it was consistency vs practicality. Giving the admin the chance to let an editor autosave a file every 100 milliseconds doesn't sound like a good idea to me. But I get the consistency argument... no veto, but wanted to express my meh.
Co-authored-by: Benedikt Kulmann <[email protected]>
kulmann
approved these changes
Feb 16, 2023
|
SonarCloud Quality Gate failed. |
ownclouders
pushed a commit
that referenced
this pull request
Feb 16, 2023
Author: Pascal Wengerter <[email protected]> Date: Thu Feb 16 23:49:36 2023 +0100 Change/streamline editor autosave (#8457) * Configurable autosave for text editor Co-authored-by: elizavetaRa <[email protected]> Co-authored-by: Elizaveta Ragozina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #8455 by bringing default configuration and streamlining autosaving for external apps (in our case DrawIo) also