Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8387 Spaces/User admin list edit quota batch actions - Followup #8438

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Feb 15, 2023

Description

See #8387

Issue

Fixes #8417

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Feb 15, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review February 15, 2023 10:58
@lookacat lookacat requested a review from kulmann February 15, 2023 12:47
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lookacat lookacat requested a review from JammingBen February 15, 2023 13:54
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last thing, please update the related changelog to contain this pr too.
Everything else, LGTM

@fschade fschade changed the title #8387 Followup #8387 Spaces/User admin list edit quota batch actions - Followup Feb 15, 2023
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit fe151df into master Feb 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the admin-list-quota-batch-action-followup branch February 15, 2023 17:21
@kulmann
Copy link
Member

kulmann commented Feb 15, 2023

one last thing, please update the related changelog to contain this pr too.
Everything else, LGTM

From what I see that was already the case :-) If I overlooked something please followup again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web] Users: Batch action "Change Quota"
4 participants