Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User management login allowed #8433

Merged
merged 23 commits into from
Feb 23, 2023
Merged

User management login allowed #8433

merged 23 commits into from
Feb 23, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Feb 15, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Feb 15, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear force-pushed the user-management-allowed branch from a089f60 to 9ecbc39 Compare February 15, 2023 07:28
@AlexAndBear AlexAndBear changed the title User management allowed User management login allowed Feb 16, 2023
@AlexAndBear AlexAndBear force-pushed the user-management-allowed branch from 2373883 to 45c8007 Compare February 16, 2023 07:38
@AlexAndBear
Copy link
Contributor Author

TBD:

  • Check with backend
  • Write e2e test

@AlexAndBear AlexAndBear reopened this Feb 16, 2023
@AlexAndBear AlexAndBear self-assigned this Feb 16, 2023
@ownclouders
Copy link
Contributor

ownclouders commented Feb 20, 2023 •
edited
Loading

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/33040/72/1
💥 The oCISTrashbinJourney tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear force-pushed the user-management-allowed branch from e147594 to 50fe418 Compare February 20, 2023 14:22
@AlexAndBear AlexAndBear mentioned this pull request Feb 21, 2023
Closed
lookacat
lookacat approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side looks good to me, one small thing

JammingBen
JammingBen suggested changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, only some tiny nitpicks from my side 🚀

In general when adding new computed props, methods etc. it would be nice to use the Composition API. Although it's a laborious step-by-step process, it will make the transition a bit easier in the end 😄

packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue Outdated Show resolved Hide resolved
tests/e2e/cucumber/features/smoke/admin-settings/users.ocis.feature Show resolved Hide resolved
tests/e2e/cucumber/steps/ui/session.ts Outdated Show resolved Hide resolved
JammingBen
JammingBen approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AlexAndBear AlexAndBear marked this pull request as ready for review February 22, 2023 11:28
@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/33040/74/1
💥 The oC10IntegrationApp1 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/33040/75/1
💥 The oC10IntegrationApp2 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/33040/73/1
💥 The oC10IntegrationNotifications tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

48.1% 48.1% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 156d02a into master Feb 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the user-management-allowed branch February 23, 2023 10:57
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@JammingBen JammingBen JammingBen approved these changes

Assignees

@AlexAndBear AlexAndBear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Dis-/enable users [admin-settings] List of users not sortable in combination with search
4 participants
@AlexAndBear @ownclouders @lookacat @JammingBen