Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix groups not updated in ui after editing user #8418

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Fix groups not updated in ui after editing user #8418

merged 4 commits into from
Feb 13, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Feb 13, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Feb 13, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 1b2d667 into master Feb 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-groups-not-updated-in-ui branch February 13, 2023 10:00
ownclouders pushed a commit that referenced this pull request Feb 13, 2023
commit 1b2d667
92baebc 
Author: Jan <[email protected]>
Date:   Mon Feb 13 11:00:53 2023 +0100

    Fix groups not updated in ui after editing user (#8418)

    * Fix groups not updated in ui after editing user

    * update changelog item

    * return promises instead of awaiting those

    * Simplify code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AlexAndBear @JammingBen