Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add groups filter to the users list #8378

Merged
merged 9 commits into from
Feb 13, 2023
Merged

Add groups filter to the users list #8378

merged 9 commits into from
Feb 13, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Feb 6, 2023 •
edited
Loading

Description

Add the possibility to filter users by their group assignments.

Needs owncloud/ocis#5533 for the server.

Screenshot

image

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Feb 6, 2023
@JammingBen
Copy link
Contributor Author

Blocked until the server side implementation is finished: owncloud/ocis#5487.

@owncloud owncloud deleted a comment from update-docs bot Feb 13, 2023
@JammingBen JammingBen marked this pull request as ready for review February 13, 2023 10:40
AlexAndBear
AlexAndBear approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit fb91aef into master Feb 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the user-groups-filter branch February 13, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Admin Settings: Filter by Group
2 participants
@JammingBen @AlexAndBear