Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OcFilterChip and ItemFilter components #8355

Merged
merged 12 commits into from
Feb 3, 2023
Merged

Add OcFilterChip and ItemFilter components #8355

merged 12 commits into from
Feb 3, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Feb 2, 2023

Description

Two components for filtering data have been added:

  • OcFilterChip - This component lies in the ODS and holds the basic design of the filter chip.
  • ItemFilter - This component lies in web-pkg and holds the basic implementation of the filter. It fills the dropdown of OcFilterChip with content and can be fed with items, which then can be selected and filtered. The component also supports multi-selection and persists the current selection as route query.

Related Issue

Screenshots (if appropriate):

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Feb 2, 2023
@JammingBen
Copy link
Contributor Author

@kulmann The current implementation turned out to be very generic already.

We have OcFilterChip in the ODS, which holds the overall chip design and provides a slot for the dropdown content as well as an event for clearing the filter.

Then there's ItemFilter in web-pkg, which basically fills in the dropdown slot of OcFilterChip. This works with any kind of items as long as they have an ID and a name.

UsersList.vue currently holds an example on how to use it. That would be the entry point for the second story.

@tbsbdr
Copy link
Contributor

tbsbdr commented Feb 2, 2023

that was fast 😳 and is already fun to click it

@JammingBen JammingBen marked this pull request as ready for review February 3, 2023 12:39
@JammingBen JammingBen requested a review from kulmann February 3, 2023 12:39
@owncloud owncloud deleted a comment from update-docs bot Feb 3, 2023
@owncloud owncloud deleted a comment from ownclouders Feb 3, 2023
@owncloud owncloud deleted a comment from ownclouders Feb 3, 2023
@owncloud owncloud deleted a comment from ownclouders Feb 3, 2023
@owncloud owncloud deleted a comment from ownclouders Feb 3, 2023
@owncloud owncloud deleted a comment from ownclouders Feb 3, 2023
@owncloud owncloud deleted a comment from ownclouders Feb 3, 2023
@owncloud owncloud deleted a comment from ownclouders Feb 3, 2023
@owncloud owncloud deleted a comment from ownclouders Feb 3, 2023
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.2% 60.2% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit fa38fa0 into master Feb 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the oc-filter branch February 3, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web, Design system] filter chip component
3 participants