Fix indirect link toggling #8308

JammingBen · 2023-01-24T11:27:23Z

Description

Toggling indirect links in the sidebar (as well as the broken sidebar state with public links with pnpm vite) has been fixed.

Related Issue

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

dschmidt · 2023-01-24T13:23:36Z

packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue

      !store.getters.configuration.options.sidebar.shares.showAllOnLoad
+    )


Does this really work? Just wrapping a value in ref() shouldn't make it reactive I thought, doesnt this need to be wrapped in computed()?

This works, yes. My idea was to make it mutable, because it needs to be written. showAllOnLoad is just the initial value.

Sounds legit @JammingBen we indeed don't want to mutate the config option in the store. using it as initial value and not persist the change in memory is a good solution. well spotted though @dschmidt I also had the same raised eyebrow feeling.

Ah, one idea for improvement though:

Suggested change

)

const indirectLinkListCollapsed = ref(linkListeCollapsed)

Otherwise you have the same store reference twice in consecutive lines.