[full-ci] Move language selection to the account page and kill settings app #8294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
requested changes
Jan 23, 2023
There was a problem hiding this comment.
Found two issues:
- the
Editbutton in the top right of the account page can be removed for ocis... there is no external editing anymore now with this PR listValuesreturnsnullif no language has been set before. Your implementation doesn't handle that, I don't see a rendered dropdown and a console error instead.
|
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/31978/53/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIAccount-accountInformation_feature-L10.png |
|
Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/31981/13/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIAccount-accountInformation_feature-L10.png |
JammingBen
changed the title
dschmidt
approved these changes
Jan 23, 2023
kulmann
approved these changes
Jan 23, 2023
| private function addAccountEditLinkToConfig(array $config): array { | ||
| $options = $config['options'] ?? []; | ||
| $serverUrl = $this->request->getServerProtocol() . '://' . $this->request->getServerHost(); | ||
| $options['accountEditLink'] = [ |
There was a problem hiding this comment.
This should only be done if the config.json loaded from disk didn't specify it on its own. I.e. if acountEditLink already exists you can return early.
kulmann
force-pushed
the
move-language-select
branch
from
96363f6 to
36cc027
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Jan 24, 2023
Author: Jannik Stehle <[email protected]> Date: Tue Jan 24 01:26:08 2023 +0100 [full-ci] Move language selection to the account page and kill settings app (#8294) * Move language selection to the account page and kill settings app Co-authored-by: Dominik Schmidt <[email protected]> Co-authored-by: Benedikt Kulmann <[email protected]>
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The language selection has been moved from the settings app to the personal account page. The settings app has been removed from the default configs because we don't need it currently.
Fixes #8290
Needs a follow-up PR in oCIS to adjust the configs there.
Screenshots (if appropriate):
Types of changes