Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3: Remove $on listeners on instances #8282

Merged
merged 6 commits into from
Jan 20, 2023
Merged

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jan 19, 2023

See https://v3-migration.vuejs.org/breaking-changes/events-api.html.

I moved quite some parts to setup() in the course of this. Also, the OcAccordion component was removed because we don't use it and it's quite painful to make it work without the listener.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jan 19, 2023
@JammingBen JammingBen requested a review from dschmidt January 20, 2023 06:59
@owncloud owncloud deleted a comment from update-docs bot Jan 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

74.1% 74.1% Coverage
0.0% 0.0% Duplication

@dschmidt dschmidt merged commit a7783de into master Jan 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the remove-on-listeners branch January 20, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants