Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Move user group select to edit panel #8279

Merged
merged 2 commits into from
Jan 24, 2023
Merged

[full-ci] Move user group select to edit panel #8279

merged 2 commits into from
Jan 24, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jan 19, 2023 •
edited
Loading

Description

image

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jan 19, 2023
kulmann
kulmann approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase 😅

@kulmann kulmann force-pushed the move-user-group-select-to-edit-panel branch 2 times, most recently from 697d520 to fdc88ff Compare January 24, 2023 00:26
@ownclouders
Copy link
Contributor

ownclouders commented Jan 24, 2023 •
edited
Loading

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32034/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L11.png

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L11.png

@ownclouders
Copy link
Contributor

ownclouders commented Jan 24, 2023 •
edited
Loading

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/32034/69/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L11.png

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L11.png

@JammingBen JammingBen force-pushed the move-user-group-select-to-edit-panel branch from fdc88ff to a10b07f Compare January 24, 2023 07:39
@JammingBen JammingBen changed the title Move user group select to edit panel [full-ci] Move user group select to edit panel Jan 24, 2023
@JammingBen JammingBen force-pushed the move-user-group-select-to-edit-panel branch from a10b07f to c553770 Compare January 24, 2023 08:01
@JammingBen JammingBen force-pushed the move-user-group-select-to-edit-panel branch from c553770 to 1f26350 Compare January 24, 2023 09:19
@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 0ecc32b into master Jan 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the move-user-group-select-to-edit-panel branch January 24, 2023 11:02
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] User: Move group assignments to Edit-Panel
3 participants
@JammingBen @ownclouders @kulmann