[full-ci] Vue 3: Fix encoded slashes in urls #8269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/31826/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31826/tracing/file-alice-2023-1-19-12-01-36.zip |
This is a follow up to #8215 where we introduced a regression, so that slashes in file paths were encoded in urls.
dschmidt
force-pushed
the
fix-patch-router
branch
from
f0d1d78 to
bbc458a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
JammingBen
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix encoded slashes in file paths in urls.
This generates correctly encoded links but does not fix up encoded links pasted to the address bar, e.g. there is no redirect from
/files/spaces/personal%2Fadminto/files/spaces/personal/admin.I've tried to implement that, but vue-router does not navigate, I assume because it thinks they are the same route anyway. It's fixed on the next navigation tho.
Related Issue
Motivation and Context
This is a follow up to #8215 where we introduced a regression
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: