Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Squash spacelist on sidebar open #8262

Merged
merged 5 commits into from
Jan 18, 2023
Merged

[full-ci] Squash spacelist on sidebar open #8262

merged 5 commits into from
Jan 18, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jan 18, 2023 •
edited
Loading

Description

See #8222

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat force-pushed the squash-spacelist-sidebar-open branch from b4371be to 76ef061 Compare January 18, 2023 09:04
@lookacat lookacat changed the title Squash spacelist on sidebar open [full-ci] Squash spacelist on sidebar open Jan 18, 2023
@lookacat lookacat force-pushed the squash-spacelist-sidebar-open branch from 76ef061 to dd2c28d Compare January 18, 2023 09:05
@lookacat lookacat marked this pull request as ready for review January 18, 2023 09:06
@lookacat lookacat requested a review from JammingBen January 18, 2023 09:06
@JammingBen
Copy link
Contributor

I think we need to hide more columns when the sidebar is opened and the screen width is < 1400px. This is with 1200px width:

image

@JammingBen
Copy link
Contributor

@lookacat Now you always hide these columns when the sidebar is opened, despite the screen width. Please combine the two, otherwise I might have enough screen space, but the columns are hidden anyways:
image

Just add a media query for <1400px for the columns you've added in 3d82988

@lookacat lookacat requested a review from JammingBen January 18, 2023 11:28
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit d7b6fb1 into master Jan 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the squash-spacelist-sidebar-open branch January 18, 2023 12:12
ownclouders pushed a commit that referenced this pull request Jan 18, 2023
@lookacat
commit d7b6fb1
2191a95 
Author: Paul Neubauer <[email protected]>
Date:   Wed Jan 18 13:12:21 2023 +0100

    [full-ci] Squash spacelist on sidebar open (#8262)

    * Squash spacelist on sidebar open

    * Add to changelog

    * Remove availableQuota

    * Hide more cells on squashed

    * Add squashed media query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @JammingBen @AlexAndBear