[full-ci][tests-only]Add internal link related e2e tests #8260
Conversation
saw-jan
force-pushed
the
addInternalLinkTests
branch
3 times, most recently
from
362a0c7 to
6377f2d
Compare
| public async newPage(newPage: Page): Promise<Page> { | ||
| // close the old page | ||
| await this.page.close() | ||
| // set the new page | ||
| this.page = newPage | ||
| return this.page | ||
| } |
There was a problem hiding this comment.
Here, actor's page will be replaced with new tab and the old tab is closed
Please, suggest if it feels odd and if you have other great ideas.
There was a problem hiding this comment.
if we can store browser context for multiple pages then it will be helpful in the future when we need to open a new page do some tasks and come back to the old page and do some task and close the old page.
Or it is not needed for now?
There was a problem hiding this comment.
IMHO may be needed in the future, but not in this PR
saw-jan
force-pushed
the
addInternalLinkTests
branch
from
6377f2d to
4cbff31
Compare
saw-jan
force-pushed
the
addInternalLinkTests
branch
2 times, most recently
from
1cbee7a to
4958bbf
Compare
| public async newPage(newPage: Page): Promise<Page> { | ||
| // close the old page | ||
| await this.page.close() | ||
| // set the new page | ||
| this.page = newPage | ||
| return this.page | ||
| } |
There was a problem hiding this comment.
if we can store browser context for multiple pages then it will be helpful in the future when we need to open a new page do some tasks and come back to the old page and do some task and close the old page.
Or it is not needed for now?
address reviews
saw-jan
force-pushed
the
addInternalLinkTests
branch
from
4958bbf to
5f05ff2
Compare
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/32288/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32288/tracing/share-a-link-with-internal-role-alice-2023-2-1-10-36-31.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32288/tracing/share-a-link-with-internal-role-brian-2023-2-1-10-36-41.zip |
saw-jan
force-pushed
the
addInternalLinkTests
branch
from
5f05ff2 to
dc4283e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Author: Amrita <[email protected]> Date: Thu Feb 2 16:14:13 2023 +0545 [full-ci][tests-only]Add internal link related e2e tests (#8260) * Add e2e tests related to internal link in personal space * refactor re-use the steps * refactor share via api for link share address reviews * check if can edit the share --------- Co-authored-by: Saw-jan <[email protected]>
Author: Amrita <[email protected]> Date: Thu Feb 2 16:14:13 2023 +0545 [full-ci][tests-only]Add internal link related e2e tests (#8260) * Add e2e tests related to internal link in personal space * refactor re-use the steps * refactor share via api for link share address reviews * check if can edit the share --------- Co-authored-by: Saw-jan <[email protected]>
Description
This PR adds an internal link related e2e tests scenario for personal space
Followup:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: