Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue 3: Use Teleport for the drag ghost item #8258

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Vue 3: Use Teleport for the drag ghost item #8258

merged 4 commits into from
Jan 18, 2023

Conversation

JammingBen
Copy link
Contributor

Description

This is needed in preparation for Vue 3 because Vue.extend() is not supported anymore.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen changed the title Use Teleport for the drag ghost item Vue 3: Use Teleport for the drag ghost item Jan 17, 2023
@JammingBen JammingBen mentioned this pull request Jan 17, 2023
Closed
29 tasks
@JammingBen JammingBen force-pushed the use-teleport-for-drag-ghost-item branch from cbc9eb8 to da06bd3 Compare January 17, 2023 16:08
@JammingBen JammingBen force-pushed the use-teleport-for-drag-ghost-item branch from da06bd3 to b28606c Compare January 17, 2023 16:23
@owncloud owncloud deleted a comment from update-docs bot Jan 17, 2023
@dschmidt
Do not make OcTable a multi root component for now
1ee05b3 
... to avoid having to deal with class inheritance
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

dschmidt
dschmidt approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh yess :)

@JammingBen JammingBen merged commit 8a23b1a into master Jan 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the use-teleport-for-drag-ghost-item branch January 18, 2023 07:36
ownclouders pushed a commit that referenced this pull request Jan 18, 2023
@JammingBen
commit 8a23b1a
02a950d 
Author: Jannik Stehle <[email protected]>
Date:   Wed Jan 18 08:36:53 2023 +0100

    Vue 3: Use Teleport for the drag ghost item (#8258)

    * Use Teleport for the drag ghost item

    * Add PR link to changelog

    * Fix warnings

    * Do not make OcTable a multi root component for now

    ... to avoid having to deal with class inheritance

    Co-authored-by: Dominik Schmidt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

Assignees

@dschmidt dschmidt

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JammingBen @dschmidt