-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix group avatar display in space members list #8248
Conversation
packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue
Outdated
Show resolved
Hide resolved
8fdea1a
to
7e7671d
Compare
PR is ready for review now. Can't review myself anymore because I took over the dev part. :-) |
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/32278/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32278/tracing/participant-management-alice-2023-1-31-08-44-17.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32278/tracing/participant-management-brian-2023-1-31-08-44-26.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32278/tracing/participant-management-marie-2023-1-31-08-44-30.zip |
7e7671d
to
72c1c7a
Compare
72c1c7a
to
cf16206
Compare
SonarCloud Quality Gate failed. |
LGTM, but I can't approve the changes since it's my PR :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approval for my code from @JammingBen (see comment) :-)
Description
The solution is not super straight-forwarded currently, unfortunately... We need to check for the presence of
collaborator.name
as space group shares don't have that property. We can't check for the share type because all user- and group-shares for spaces have the exact same share type.Edit: we've introduced a
shareType 8
for groups as space members. With that it's pretty much straightforward now.Related Issue
Types of changes
Open tasks