[full-ci] Admin: Spaces actions in sidebar #8233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
changed the title
JammingBen
reviewed
Jan 13, 2023
packages/web-app-admin-settings/src/components/Spaces/SideBar/ActionsPanel.vue
Outdated
Show resolved
Hide resolved
packages/web-app-admin-settings/src/components/Spaces/SideBar/ActionsPanel.vue
Outdated
Show resolved
Hide resolved
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/31557/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31557/tracing/participant-management-alice-2023-1-13-02-27-37.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31557/tracing/participant-management-anonymous-2023-1-13-02-28-10.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31557/tracing/participant-management-brian-2023-1-13-02-27-46.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31557/tracing/participant-management-carol-2023-1-13-02-27-58.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31557/tracing/participant-management-marie-2023-1-13-02-27-50.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31557/tracing/participant-management-richard-2023-1-13-02-27-53.zip |
lookacat
changed the title
lookacat
force-pushed
the
admin-panel-spaces-actions-sidebar
branch
2 times, most recently
from
426f1e1 to
6797726
Compare
kulmann
requested changes
Jan 16, 2023
Yeah we did, but decided against it eventually, mainly because of:
|
|
@kulmann can we merge it? |
JammingBen
force-pushed
the
admin-panel-spaces-actions-sidebar
branch
from
6797726 to
bdb30eb
Compare
JammingBen
approved these changes
Jan 18, 2023
kulmann
force-pushed
the
admin-panel-spaces-actions-sidebar
branch
from
bdb30eb to
0f1dc50
Compare
kulmann
approved these changes
Jan 23, 2023
| component: MembersPanel, | ||
| default: false, | ||
| enabled: unref(selectedSpaces).length === 1, | ||
| componentAttrs: { | ||
| spaceResource: unref(selectedSpaces)[0] | ||
| } | ||
| }, | ||
| { | ||
| app: 'SpaceActions', |
There was a problem hiding this comment.
Please insert the Actions panel before the Members panel. Otherwise the order of panels is inconsistent in the files app (project spaces overview) and here in the admin settings app.
There was a problem hiding this comment.
(took care myself, so that we can merge this asap)
|
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
bot
deleted the
admin-panel-spaces-actions-sidebar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #8222
Related Issue
Types of changes
Checklist: