Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaces management details action #8231

Merged
merged 7 commits into from
Jan 13, 2023
Merged

Spaces management details action #8231

merged 7 commits into from
Jan 13, 2023

Conversation

JammingBen
Copy link
Contributor

Description

This adds the "Show Details"-action to the actions in the spaces management.

Some technical background: The useSidebar composable has been moved from web-app-files to web-pkg so we can use it in the admin-settings.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jan 13, 2023
@JammingBen JammingBen force-pushed the spaces-management-details-action branch 4 times, most recently from 35052fd to 87b877a Compare January 13, 2023 10:39
@JammingBen JammingBen mentioned this pull request Jan 13, 2023
Closed
4 tasks
@JammingBen JammingBen force-pushed the spaces-management-details-action branch from 87b877a to a36203f Compare January 13, 2023 12:06
@owncloud owncloud deleted a comment from update-docs bot Jan 13, 2023
@JammingBen JammingBen marked this pull request as ready for review January 13, 2023 12:31
kulmann
kulmann approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky that you also moved the useSidebar composable to web-pkg in this PR. 😁 Awesome! 🚀

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

78.8% 78.8% Coverage
1.3% 1.3% Duplication

@JammingBen JammingBen merged commit cf76434 into master Jan 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the spaces-management-details-action branch January 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JammingBen @kulmann