Vue 3: Port to @vueuse/head (and get rid of vue-meta) #8221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
approved these changes
Jan 12, 2023
|
SonarCloud Quality Gate failed. |
kulmann
reviewed
Jan 12, 2023
| @@ -82,6 +83,9 @@ export const renderSuccess = (): void => { | |||
| wormhole: instance.config.globalProperties.$wormhole | |||
| }) | |||
|
|
|||
| // @vueuse/head | |||
There was a problem hiding this comment.
What's this comment needed for?
There was a problem hiding this comment.
Clarified in a call: just for consistency, because the other blocks also have a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port to @vueuse/head (and get rid of vue-meta)
I tried to make the new (alpha) version of vue-meta work, but couldn't and then chose to go with
@vueuse/headwhich I trust more to be properly maintained in the long run and also offers us a nice composition api.Types of changes
Checklist:
Open tasks: