Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Vue 3: Use createApp and update portal-vue #8214

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Conversation

dschmidt
Copy link
Member

Description

Use new Vue 3 createApp api and update portal-vue.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jan 11, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Jan 11, 2023

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/31414/70/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L112.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L112.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L132.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L132.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L139.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L139.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L147.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L147.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L157.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L157.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L167.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L167.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L179.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L179.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L187.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L187.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L197.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L197.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L207.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L207.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L225.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L225.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L234.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L234.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L254.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L254.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L263.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L263.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L33.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L33.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L34.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L34.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L35.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L35.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L54.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L54.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L55.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L55.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L56.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L56.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L59.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L59.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L77.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L77.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L91.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L91.png

@dschmidt dschmidt changed the title Vue 3: Use createApp and update portal-vue [full-ci] Vue 3: Use createApp and update portal-vue Jan 11, 2023
@ownclouders
Copy link
Contributor

ownclouders commented Jan 11, 2023

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/31414/14/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUICreateFilesFolders-createFile_feature-L13.png

webUICreateFilesFolders-createFile_feature-L13.png

webUICreateFilesFolders-createFile_feature-L19.png

webUICreateFilesFolders-createFile_feature-L19.png

webUICreateFilesFolders-createFile_feature-L25.png

webUICreateFilesFolders-createFile_feature-L25.png

webUICreateFilesFolders-createFile_feature-L31.png

webUICreateFilesFolders-createFile_feature-L31.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L19.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L19.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L20.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L20.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L21.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L21.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L22.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L22.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L23.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L23.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L24.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L24.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L25.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L25.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L26.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L26.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L43.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L43.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L44.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L44.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L60.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L60.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L61.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L61.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L62.png

webUICreateFilesFolders-createFolderEdgeCases_feature-L62.png

webUICreateFilesFolders-createFolders_feature-L12.png

webUICreateFilesFolders-createFolders_feature-L12.png

webUICreateFilesFolders-createFolders_feature-L22.png

webUICreateFilesFolders-createFolders_feature-L22.png

webUICreateFilesFolders-createFolders_feature-L27.png

webUICreateFilesFolders-createFolders_feature-L27.png

webUICreateFilesFolders-createFolders_feature-L33.png

webUICreateFilesFolders-createFolders_feature-L33.png

webUICreateFilesFolders-createFolders_feature-L41.png

webUICreateFilesFolders-createFolders_feature-L41.png

webUICreateFilesFolders-createFolders_feature-L47.png

webUICreateFilesFolders-createFolders_feature-L47.png

webUICreateFilesFolders-createFolders_feature-L53.png

webUICreateFilesFolders-createFolders_feature-L53.png

webUICreateFilesFolders-createFolders_feature-L61.png

webUICreateFilesFolders-createFolders_feature-L61.png

webUICreateFilesFolders-createFolders_feature-L74.png

webUICreateFilesFolders-createFolders_feature-L74.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L10.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L10.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L114.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L114.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L126.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L126.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L135.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L135.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L155.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L155.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L189.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L189.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L208.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L208.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L226.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L226.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L248.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L248.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L51.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L51.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L52.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L52.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L53.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L53.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L54.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L54.png

@dschmidt
Copy link
Member Author

3.0.0 final is released, I'd appreciate if someone could update the pr tomorrow morning

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.4% 15.4% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann merged commit d6c3c51 into master Jan 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the vue3-portal-vue branch January 12, 2023 09:37
ownclouders pushed a commit that referenced this pull request Jan 12, 2023
Merge: c20ecd2 7db4ea4
Author: Benedikt Kulmann <[email protected]>
Date:   Thu Jan 12 10:37:28 2023 +0100

    Merge pull request #8214 from owncloud/vue3-portal-vue

    [full-ci] Vue 3: Use createApp and update portal-vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants