Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search bar input appearance #8203

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jan 10, 2023

Description

The broken appearance of the search bar input field has been fixed.

Note: The priority of CSS rules seem to differ between pnpm build and pnpm vite. With pnpm vite, the CSS rules in ODS have a higher prio, which is correct. Somehow this changes with pnpm build. That might be worth debugging in the future, but for now, we are fine with simply adding !important (like we often do in the ODS).

image

Issue

Fixes #8158

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jan 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@kulmann kulmann merged commit a31c402 into master Jan 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-search-bar-input-appearance branch January 10, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search icon overlap in search bar
2 participants