-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3: Remove vue-async-computed
extension
#8201
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't work to full extent: when I click multiple images in a row without waiting for the previews to load, I sometimes get the preview of a previously selected file.
@kulmann Thx for the hint! Could you please try again? |
@kulmann when you re-test, can you check whether you think |
I agree, doesn't seem to be needed anymore. And the assignment to |
Works now :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thank you 💪
Kudos, SonarCloud Quality Gate passed! |
Description
We've removed the
vue-async-computed
extension because it was broken in the right sidebar and we want to use vue-concurrency for such things anyway.Types of changes