Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3: Remove vue-async-computed extension #8201

Merged
merged 4 commits into from
Jan 10, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jan 10, 2023

Description

We've removed the vue-async-computed extension because it was broken in the right sidebar and we want to use vue-concurrency for such things anyway.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@update-docs
Copy link

update-docs bot commented Jan 10, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen marked this pull request as ready for review January 10, 2023 10:48
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray 🥳

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work to full extent: when I click multiple images in a row without waiting for the previews to load, I sometimes get the preview of a previously selected file.

@JammingBen
Copy link
Contributor Author

@kulmann Thx for the hint! Could you please try again?

@JammingBen JammingBen requested a review from kulmann January 10, 2023 11:05
@dschmidt
Copy link
Member

@kulmann when you re-test, can you check whether you think yield new Promise((resolve) => setTimeout(resolve, 500)) is still neccessary? I don't see any flickering

@kulmann
Copy link
Member

kulmann commented Jan 10, 2023

@kulmann when you re-test, can you check whether you think yield new Promise((resolve) => setTimeout(resolve, 500)) is still neccessary? I don't see any flickering

I agree, doesn't seem to be needed anymore. And the assignment to preview.value could be inlined instead of assigning yield loadPreview(...) to a variable and then assigning that to preview.value.

@kulmann
Copy link
Member

kulmann commented Jan 10, 2023

@kulmann Thx for the hint! Could you please try again?

Works now :-)

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you 💪

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.4% 81.4% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 5f72f48 into master Jan 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the remove-vue-async-computed branch January 10, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants