Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue 3: eslint rules and various deprecation fixes #8198

Merged
merged 11 commits into from
Jan 10, 2023
Merged

Vue 3: eslint rules and various deprecation fixes #8198

merged 11 commits into from
Jan 10, 2023

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Jan 9, 2023

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jan 9, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dschmidt dschmidt changed the title Vue 3: Enable Vue 3 eslint rules Vue 3: eslint rules and various deprecation fixes Jan 9, 2023
@dschmidt dschmidt force-pushed the eslint-vue3 branch 2 times, most recently from 9656418 to 829dce1 Compare January 10, 2023 00:01
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

69.9% 69.9% Coverage
0.9% 0.9% Duplication

kulmann
kulmann approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@kulmann kulmann merged commit 574913f into master Jan 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the eslint-vue3 branch January 10, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschmidt @kulmann