Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add custom permission e2e tests #8193

Merged
merged 1 commit into from
Jan 23, 2023
Merged

[tests-only][full-ci]Add custom permission e2e tests #8193

merged 1 commit into from
Jan 23, 2023

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Jan 9, 2023 •
edited
Loading

Description

This Pr refactor codes related to custom permission for resource to work for file.

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@amrita-shrestha amrita-shrestha self-assigned this Jan 9, 2023
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 9, 2023
Closed
18 tasks
@ownclouders
Copy link
Contributor

ownclouders commented Jan 9, 2023 •
edited
Loading

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/31437/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31437/tracing/file-alice-2023-1-12-08-57-13.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31437/tracing/file-brian-2023-1-12-08-57-23.zip

@amrita-shrestha amrita-shrestha force-pushed the addCustomPermissionTests branch 3 times, most recently from 42ceb82 to e9d1837 Compare January 9, 2023 10:52
@amrita-shrestha amrita-shrestha marked this pull request as ready for review January 9, 2023 10:54
@saw-jan
Copy link
Member

saw-jan commented Jan 10, 2023

@amrita-shrestha, target stable branch first.

@amrita-shrestha
Copy link
Contributor Author

amrita-shrestha commented Jan 12, 2023 •
edited
Loading

@amrita-shrestha, target stable branch first.

@saw-jan when i started this PR all changes were not present in stable so I did my PR in master

@saw-jan
Copy link
Member

saw-jan commented Jan 12, 2023

when i started this PR all changes were not present in stable so I did my PR in master

You can change the target now as well if you want. It would be easier if we maintain the flow

@amrita-shrestha amrita-shrestha changed the base branch from master to stable-6.0 January 12, 2023 07:56
@amrita-shrestha amrita-shrestha changed the base branch from stable-6.0 to master January 12, 2023 07:57
@amrita-shrestha amrita-shrestha force-pushed the addCustomPermissionTests branch 2 times, most recently from b36145d to 486ce2d Compare January 12, 2023 08:42
@amrita-shrestha amrita-shrestha force-pushed the addCustomPermissionTests branch from 486ce2d to 7616d86 Compare January 12, 2023 09:54
saw-jan
saw-jan reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookign good 👍

SagarGi
SagarGi reviewed Jan 16, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 👍 Please rebase it.

@amrita-shrestha amrita-shrestha force-pushed the addCustomPermissionTests branch from 7616d86 to ff8bc24 Compare January 17, 2023 07:41
@ownclouders
Copy link
Contributor

ownclouders commented Jan 17, 2023 •
edited
Loading

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/31701/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31701/tracing/participant-management-alice-2023-1-17-08-39-16.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31701/tracing/participant-management-anonymous-2023-1-17-08-39-49.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31701/tracing/participant-management-brian-2023-1-17-08-39-25.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31701/tracing/participant-management-carol-2023-1-17-08-39-38.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31701/tracing/participant-management-marie-2023-1-17-08-39-29.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31701/tracing/participant-management-richard-2023-1-17-08-39-33.zip

@amrita-shrestha amrita-shrestha force-pushed the addCustomPermissionTests branch 2 times, most recently from e258b41 to c1bf53c Compare January 18, 2023 07:07
@amrita-shrestha amrita-shrestha force-pushed the addCustomPermissionTests branch 2 times, most recently from 4c74bd7 to 9af16fc Compare January 18, 2023 07:13
ScharfViktor
ScharfViktor approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amrita-shrestha @saw-jan
Add custom permission test for personal space
addcc6c 
Added custom Persion for both file and folder

Refactor share related steps
@saw-jan saw-jan mentioned this pull request Jan 23, 2023
Merged
9 tasks
@saw-jan saw-jan force-pushed the addCustomPermissionTests branch from 9af16fc to addcc6c Compare January 23, 2023 04:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit ef42754 into master Jan 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the addCustomPermissionTests branch January 23, 2023 04:56
ownclouders pushed a commit that referenced this pull request Jan 23, 2023
@saw-jan
commit ef42754
aacf22a 
Merge: c866480 addcc6c
Author: Sawjan Gurung <[email protected]>
Date:   Mon Jan 23 10:41:00 2023 +0545

    Merge pull request #8193 from owncloud/addCustomPermissionTests

    [tests-only][full-ci]Add custom permission e2e tests
@saw-jan
Copy link
Member

saw-jan commented Jan 23, 2023 •
edited
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan left review comments

@ScharfViktor ScharfViktor ScharfViktor approved these changes

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amrita-shrestha @ownclouders @saw-jan @SagarGi @ScharfViktor