[full-ci] Add admin space sidebar details

[lookacat]

Description

See #8219

Related Issue

• Fixes [Web] Right sidebar for single Space #8219

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[JammingBen]

I find the panels a bit confusing at the moment. We have SpaceDetails if one space is selected and we have DetailsPanel if no or >1 spaces are selected. I would go for one of the following:

• Use one panel (SpaceDetails) to handle all cases. Problem with this approach is that the SpaceDetails panel is used in the files-app as well, where we don't want this. Hence I'd rather do it like it's done in the files-app already:
• Have 3 separate panels for all 3 cases: NoSelection (0 spaces), SpaceDetails (1 space), SpaceDetailsMultiple (2 or more spaces). Those components can live in web-pkg because we might re-use them in the files app as well. The check which panels needs to be displayed would then be done in packages/web-app-admin-settings/src/views/Spaces.vue via the enabled prop of each panel.

And we also need to make sure to not display the space image in SpaceDetails in the admin-settings. You could just introduce another property showImage which defaults to true.

[JammingBen]

Nice 👍 Just a few minor things I've noticed.

[kulmann]

I think the Details folder should have another parent folder named Spaces. And then please move SpaceNoSelection.vue one level up. Result should be this layout:

- Spaces
  - Details
    - SpaceDetails.vue
    - SpaceDetailsMultiple.vue
  - SpaceNoSelection.vue

In a followup PR you could make use of the SpaceNoSelection component in the Projects.vue view of the files app.

[kulmann]

Please open a followup issue, the multi selected space panel could show some more info. E.g. how many spaces are selected and what their combined quota values are (total, remaining, used).

[lookacat]

Followup: #8222

[kulmann]

https://github.com/owncloud/web/pull/8192/files#r1067973359 is still unresolved. Other than that good now. Please also add tests in a followup.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

69.5% Coverage
0.4% Duplication