Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] e2eTest. Api step. create folder in personal space #8176

Merged
merged 5 commits into from
Jan 4, 2023
Merged

[tests-only] e2eTest. Api step. create folder in personal space #8176

merged 5 commits into from
Jan 4, 2023

Conversation

ScharfViktor
Copy link
Contributor

part of #8101

  • user creates folder in the personal space

@update-docs
Copy link

update-docs bot commented Jan 3, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor mentioned this pull request Jan 3, 2023
Closed
18 tasks
@ownclouders
Copy link
Contributor

ownclouders commented Jan 3, 2023 •
edited
Loading

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/31146/11/1
💥 The e2e-oc10 tests pipeline failed. The build has been cancelled.

SagarGi
SagarGi reviewed Jan 4, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍

tests/e2e/cucumber/features/smoke/reshare.feature Outdated Show resolved Hide resolved
tests/e2e/cucumber/steps/api.ts Outdated Show resolved Hide resolved
@SagarGi SagarGi requested a review from SwikritiT January 4, 2023 04:21
@SwikritiT SwikritiT changed the title [test-only] e2eTest. Api step. create folder in personal space [tests-only] e2eTest. Api step. create folder in personal space Jan 4, 2023
@SagarGi
Copy link
Member

SagarGi commented Jan 4, 2023 •
edited
Loading

@ScharfViktor #8170 this PR required to create folder inside space. I have used your code to implement it. So you may not need make another PR to create folder inside space.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan reviewed Jan 4, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SagarGi
Copy link
Member

SagarGi commented Jan 4, 2023

@ScharfViktor can you merge this today if possible. i will be rebasing it for my PR.

@ScharfViktor ScharfViktor merged commit 207fa58 into master Jan 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the createFolderInPersonalSpace branch January 4, 2023 14:16
ownclouders pushed a commit that referenced this pull request Jan 4, 2023
@ScharfViktor
commit 207fa58
c76b05a 
Author: Viktor Scharf <[email protected]>
Date:   Wed Jan 4 15:16:18 2023 +0100

    [tests-only] e2eTest. Api step. create folder in personal space (#8176)

    * create folder in personal space
@SagarGi SagarGi mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@SagarGi SagarGi SagarGi approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScharfViktor @ownclouders @SagarGi @SwikritiT @saw-jan