[full-ci] Enhancement: Show text file icon for empty text files #8057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookacat
force-pushed
the
enhancement-show-txt-icon-for-empty-txt-files
branch
from
ae38758 to
caa3b6f
Compare
lookacat
changed the title
lookacat
force-pushed
the
enhancement-show-txt-icon-for-empty-txt-files
branch
from
caa3b6f to
7242496
Compare
|
Results for oC10Sharing1 https://drone.owncloud.com/owncloud/web/30292/23/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingExpirationDate-shareWithExpirationDate_feature-L14.pngwebUISharingExpirationDate-shareWithExpirationDate_feature-L21.png |
kulmann
requested changes
Dec 2, 2022
packages/design-system/src/components/OcResource/OcResource.vue
Outdated
Show resolved
Hide resolved
kulmann
requested changes
Dec 9, 2022
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Dec 12, 2022
delete-merged-branch
bot
deleted the
enhancement-show-txt-icon-for-empty-txt-files
branch
ownclouders
pushed a commit
that referenced
this pull request
Dec 12, 2022
Author: Paul Neubauer <[email protected]> Date: Mon Dec 12 14:48:57 2022 +0100 [full-ci] Enhancement: Show text file icon for empty text files (#8057)
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When having an almost empty txt file the thumbnail shows just a white square which looks weird.
We now replaced the thumbnail with the txt file icon for almost empty files.
Motivation and Context
Make UI not look bugged
Screenshots (if appropriate):
Before (all empty)
After (all empty have txt file icon, the one with content displays a thumbnail)
Types of changes
Checklist: