Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preload images #8051

Merged
merged 15 commits into from
Dec 13, 2022
Merged

Preload images #8051

merged 15 commits into from
Dec 13, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Dec 1, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Dec 1, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait2 https://drone.owncloud.com/owncloud/web/30272/46/1
💥 The oC10XGAPortrait2 tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear requested a review from dschmidt December 12, 2022 09:37
@AlexAndBear AlexAndBear requested a review from kulmann December 12, 2022 09:53
@AlexAndBear AlexAndBear marked this pull request as ready for review December 12, 2022 09:53
kulmann
kulmann requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! Some small nitpicks about code duplication (see comments). Most important: I'd like to see unit tests 🙈

packages/web-app-preview/src/App.vue Outdated Show resolved Hide resolved
packages/web-app-preview/src/App.vue Outdated Show resolved Hide resolved
dschmidt
dschmidt requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one but important nitpick - otherwise pretty nice, I'm always amazed how things that bend your brain turn out to be so little code in the end, good job!

Test would be indeed be nice, tho :)

packages/web-app-preview/src/App.vue Outdated Show resolved Hide resolved
@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Dec 12, 2022 •
edited
Loading

Just one but important nitpick - otherwise pretty nice, I'm always amazed how things that bend your brain turn out to be so little code in the end, good job!

Test would be indeed be nice, tho :)

Haha thank you, but this thing gave me major headaches.

dschmidt
dschmidt approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see the loading spinner flickering when I switch through the pics hammering on the arrow keys, but I guess that can be taken care of when you add transitions :trollface:

Really nice improvement anyhow!

@AlexAndBear AlexAndBear requested a review from kulmann December 13, 2022 09:29
kulmann
kulmann approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit b62a9aa into master Dec 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/2052 branch December 13, 2022 12:19
ownclouders pushed a commit that referenced this pull request Dec 13, 2022
commit b62a9aa
27a382f 
Author: Jan <[email protected]>
Date:   Tue Dec 13 13:19:48 2022 +0100

    Preload images (#8051)
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt dschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media viewer preloading
4 participants
@AlexAndBear @ownclouders @dschmidt @kulmann