-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Dedupe CSS #8041
[full-ci] Dedupe CSS #8041
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oC10SharingIntGroups https://drone.owncloud.com/owncloud/web/30265/25/1 |
de1d616
to
385d160
Compare
I replaced the The only real exception is the extension of the Let's see what pipeline says. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay 🥳
SonarCloud Quality Gate failed. |
The only failing tests are unrelated to this PR, see #8042 |
Sweeeeet! |
Description
This PR aims to remove the duplicated CSS caused by imports in the design-system.
It's not perfect yet, breadcrumbs are broken and input fields (like the search input) look wrong, otherwise it seems to work fairly ok.I would be glad if someone with more knowledge of the styles in this project to pick this up and fix the remaining issues.Thanks to @JammingBen for stepping up and taking care of the issues I had left open!🏅
I have applied the same approach in my vite PR, there everything is even a little more sophisticated
(and has the same issues)works the same way, so I'd say finishing this, would be a good preparation for solving this in Vite as well.Related Issue
Motivation and Context
Since we imported the ODS into this repo, we have a lot of duplicated styles through imports in the ODS components. This slows down the dev tools a lot and (if not stripped in production builds) bloats the built assets.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: