Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement zoom and rotate for preview app #7977

Merged
merged 8 commits into from
Nov 28, 2022
Merged

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 16, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Nov 16, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Nov 16, 2022

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/29905/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L62.png

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L62.png

💥 The oC10SharingPublic2 tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear changed the title Implement zoom Implement zoom and rotate for preview app Nov 16, 2022
@AlexAndBear AlexAndBear marked this pull request as ready for review November 16, 2022 14:08
@AlexAndBear
Copy link
Contributor Author

I really don't know what to "unit-test" here

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The controls for zoom feel a bit jumpy, depending on the percentage value shown in the controls. Could you make this a fixed width somehow?
Other than that only a nitpick about some code deduplication. Feature itself works like a charm, I love it!

I was a bit irritated that the zoom and rotate controls only appear after the image is loaded (that looks funny when browsing through a folder of only images, because the zoom and rotate controls disappear and then reappear all the time). But that will be somewhat fixed when we introduce preloading of images. So nothing we need to worry about here.

packages/web-app-preview/src/App.vue Outdated Show resolved Hide resolved
@AlexAndBear
Copy link
Contributor Author

Thx for the feedback!

@AlexAndBear AlexAndBear requested a review from kulmann November 28, 2022 08:46
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 😍

@kulmann kulmann merged commit 1d5de4a into master Nov 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the preview-app-zoom-and-rotate branch November 28, 2022 11:09
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Preview: Missing zoom and rotate options
3 participants