Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Refactor webdav listFiles #7880

Merged
merged 11 commits into from
Nov 3, 2022
Merged

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Oct 26, 2022

Description

Refactor webDav listFiles so the result isn't only an array but rather an object containing the requested node and its children.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests updated
  • Acceptance tests added

@update-docs
Copy link

update-docs bot commented Oct 26, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat changed the title Refactor Webdav listFiles [full-ci] Refactor webdav listFiles Oct 27, 2022
@lookacat lookacat requested review from dschmidt and kulmann October 27, 2022 08:29
@lookacat lookacat marked this pull request as ready for review October 27, 2022 08:29
@ownclouders
Copy link
Contributor

ownclouders commented Oct 27, 2022

Results for oC10Files3 https://drone.owncloud.com/owncloud/web/29536/19/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPreview-mediaPreview_feature-L106.png

webUIPreview-mediaPreview_feature-L106.png

webUIPreview-mediaPreview_feature-L114.png

webUIPreview-mediaPreview_feature-L114.png

webUIPreview-mediaPreview_feature-L122.png

webUIPreview-mediaPreview_feature-L122.png

webUIPreview-mediaPreview_feature-L138.png

webUIPreview-mediaPreview_feature-L138.png

webUIPreview-mediaPreview_feature-L139.png

webUIPreview-mediaPreview_feature-L139.png

webUIPreview-mediaPreview_feature-L14.png

webUIPreview-mediaPreview_feature-L14.png

webUIPreview-mediaPreview_feature-L140.png

webUIPreview-mediaPreview_feature-L140.png

webUIPreview-mediaPreview_feature-L143.png

webUIPreview-mediaPreview_feature-L143.png

webUIPreview-mediaPreview_feature-L15.png

webUIPreview-mediaPreview_feature-L15.png

webUIPreview-mediaPreview_feature-L153.png

webUIPreview-mediaPreview_feature-L153.png

webUIPreview-mediaPreview_feature-L16.png

webUIPreview-mediaPreview_feature-L16.png

webUIPreview-mediaPreview_feature-L18.png

webUIPreview-mediaPreview_feature-L18.png

webUIPreview-mediaPreview_feature-L56.png

webUIPreview-mediaPreview_feature-L56.png

webUIPreview-mediaPreview_feature-L57.png

webUIPreview-mediaPreview_feature-L57.png

webUIPreview-mediaPreview_feature-L60.png

webUIPreview-mediaPreview_feature-L60.png

webUIPreview-mediaPreview_feature-L68.png

webUIPreview-mediaPreview_feature-L68.png

webUIPreview-mediaPreview_feature-L77.png

webUIPreview-mediaPreview_feature-L77.png

webUIPreview-mediaPreview_feature-L84.png

webUIPreview-mediaPreview_feature-L84.png

webUIPreview-mediaPreview_feature-L91.png

webUIPreview-mediaPreview_feature-L91.png

webUIPreview-mediaPreview_feature-L98.png

webUIPreview-mediaPreview_feature-L98.png

@lookacat lookacat force-pushed the refactor-webdav-list-files branch from ae888bd to 782d9ab Compare October 27, 2022 11:53
@lookacat lookacat force-pushed the refactor-webdav-list-files branch from 782d9ab to a3cce71 Compare November 2, 2022 10:44
@lookacat lookacat requested a review from kulmann November 2, 2022 13:11
@lookacat lookacat requested a review from dschmidt November 3, 2022 09:06
@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

31.6% 31.6% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 3085d38 into master Nov 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the refactor-webdav-list-files branch November 3, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants