Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selectable share permissions for re-shares #7844

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

JammingBen
Copy link
Contributor

Description

We've fixed a bug where the selectable roles on a re-share could exceed the parent share's permissions in certain scenarios.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Oct 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

20.5% 20.5% Coverage
37.3% 37.3% Duplication

@JammingBen JammingBen marked this pull request as ready for review October 21, 2022 13:24
@JammingBen JammingBen requested a review from kulmann October 21, 2022 13:25
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces quite some code duplication with the private link resolving 🤔 Does it make sense to port the composable to web-pkg?

@JammingBen
Copy link
Contributor Author

This introduces quite some code duplication with the private link resolving 🤔 Does it make sense to port the composable to web-pkg?

I had the same idea but some parts differ a bit, and either way, it's only temporary solution. Hence I figured to leave it. What do you think?

@JammingBen JammingBen merged commit 22b5181 into master Oct 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-reshare-selectable-permissions branch October 24, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong share permissions for re-shares from "Shared with others/via link" page
2 participants