Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar when no highlighted resource is present #7826

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

JammingBen
Copy link
Contributor

Description

Sidebar panels that require a resource now won't be loaded without such. This fixes a bug where navigating with an open sidebar would break it.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Oct 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.5% 95.5% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review October 19, 2022 09:40
@JammingBen JammingBen merged commit fc32048 into master Oct 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-sidebar-without-highlighted-resource branch October 19, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigating inside the share jail with opened sidebar breaks the shares panel
2 participants