Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'X-Request-ID' header to all outgoing requests #7800

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Add 'X-Request-ID' header to all outgoing requests #7800

merged 4 commits into from
Oct 14, 2022

Conversation

JammingBen
Copy link
Contributor

Description

X-Request-ID headers have been added to all outgoing requests to make the tracing of requests easier.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Oct 14, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

36.8% 36.8% Coverage
0.0% 0.0% Duplication

@kulmann
Copy link
Contributor

kulmann commented Oct 14, 2022

@JammingBen what's needed to get this out of draft mode?

@JammingBen JammingBen marked this pull request as ready for review October 14, 2022 11:37
@kulmann
Copy link
Contributor

kulmann commented Oct 14, 2022

cc @michaelstingl 😉

@JammingBen JammingBen merged commit 0b29042 into master Oct 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-x-request-id branch October 14, 2022 11:45
@micbar
Copy link
Contributor

micbar commented Oct 14, 2022

@JammingBen @kulmann Wow! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send unique X-Request-ID header to allow tracing requests
3 participants
@JammingBen @kulmann @micbar