Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: file list update after copying resources #7797

Merged
merged 1 commit into from
Oct 14, 2022
Merged

fix: file list update after copying resources #7797

merged 1 commit into from
Oct 14, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Oct 14, 2022

Description

Fixing an issue with file list updates after coyping resources that was introduced when we added path correction based on fileIds.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Oct 14, 2022
@kulmann kulmann mentioned this pull request Oct 14, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

JammingBen
JammingBen approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit 83fc6c8 into master Oct 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-file-list-update-after-copy branch October 14, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replacing a file results in duplicate resource (only UI glitch)
2 participants
@kulmann @JammingBen