-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] added search test for project spce #7743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagarGi
reviewed
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
SwikritiT
changed the title
[test-only] added search test for project spce
[tests-only] added search test for project spce
Oct 10, 2022
SwikritiT
reviewed
Oct 10, 2022
tests/e2e/cucumber/features/integrations/searchProjectSpace.ocis.feature
Outdated
Show resolved
Hide resolved
SwikritiT
reviewed
Oct 10, 2022
tests/e2e/cucumber/features/integrations/searchProjectSpace.ocis.feature
Outdated
Show resolved
Hide resolved
could you have look it again? |
SwikritiT
reviewed
Oct 11, 2022
tests/e2e/cucumber/features/integrations/searchProjectSpace.ocis.feature
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
SwikritiT
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searchProjectSpace.ocis.feature
for ocis (project space), where I tried to find an object with special characters. Need add "?" and ":" characters after fixing "Precondition Failed" when uploading a file into a folder with the "?" character ocis#4745 and Searching for the ":" character gives 500 ocis#4744search.feature
. made it more readable. Changed step "find in current folder" because we don't send PROPFIND request. more detail here: Fix debounced search #7730 (comment)