Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Enable the e2e test steps related to issue-7629 #7722

Merged
merged 1 commit into from
Sep 30, 2022
Merged

[tests-only] Enable the e2e test steps related to issue-7629 #7722

merged 1 commit into from
Sep 30, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Sep 30, 2022 •
edited
Loading

Description

Some tests steps were commented due to this issue #7629 , but seems like it's fixed now, so enabling them again

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@SwikritiT SwikritiT self-assigned this Sep 30, 2022
@SwikritiT SwikritiT marked this pull request as ready for review September 30, 2022 10:36
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT requested a review from SagarGi September 30, 2022 11:11
@SwikritiT SwikritiT mentioned this pull request Sep 30, 2022
Closed
SagarGi
SagarGi reviewed Sep 30, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SwikritiT SwikritiT merged commit a26f2b3 into master Sep 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the enable-commented-steps branch September 30, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi approved these changes

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwikritiT @SagarGi